Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nsis): support choosing compression algorithms, closes #7685 #7729

Closed
wants to merge 458 commits into from

Conversation

pewsheen
Copy link
Contributor

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Docs
  • New Binding issue #___
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change?

Checklist

  • When resolving issues, they are referenced in the PR's title (e.g fix: remove a typo, closes #___, #___)
  • A change file is added if any packages will require a version bump due to this PR per the instructions in the readme.
  • I have added a convincing reason for adding this feature, if necessary

Other information

lucasfernog and others added 30 commits March 16, 2023 09:51
…i-apps#6468)

* refactor(core): remove attohttpc client, closes tauri-apps#6415

* lint [skip ci]
* chore(deps): pin wry to 0.27

* update index.js [skip ci]

* fmt
…i-apps#6476)

* fix(ios): link clang_rt.ios to include isPlatformVersionAtLeast

See alexcrichton/curl-rust#283

* lint [skip ci]

* update swift-rs to 1.0.2
…auri-apps#6490)

* refactor(build): change tauri-api dependency path to skip rebuilds

The tauri-api Swift package cannot be injected inside the iOS plugin project because swift-rs reruns when the project folder changes. We will now inject the project in the parent folder instead.

* revert tauri-plugin-log [skip ci]
* fix(ci): enable openssl vendored feature for cli.js

* enable feature on CI

* add openssl dep

* avoid openssl on Linux

* vendored openssl on macOS CI

* fix dep install

* lint [skip ci]
@pewsheen pewsheen requested a review from a team as a code owner August 31, 2023 11:57
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of docs changes and naming consistency

core/tauri-utils/src/config.rs Outdated Show resolved Hide resolved
tooling/bundler/src/bundle/settings.rs Outdated Show resolved Hide resolved
core/tauri-utils/src/config.rs Outdated Show resolved Hide resolved
core/tauri-utils/src/config.rs Outdated Show resolved Hide resolved
core/tauri-utils/src/config.rs Show resolved Hide resolved
core/tauri-utils/src/config.rs Show resolved Hide resolved
tooling/bundler/src/bundle/windows/nsis.rs Outdated Show resolved Hide resolved
tooling/bundler/src/bundle/windows/templates/installer.nsi Outdated Show resolved Hide resolved
tooling/bundler/src/bundle/windows/nsis.rs Outdated Show resolved Hide resolved
tooling/bundler/src/bundle/windows/templates/installer.nsi Outdated Show resolved Hide resolved
Copy link
Member

@amrbashir amrbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just noticed that this was opened against dev, let's rebase and open it against 1.x so we could roll it out in 1.5

This reverts commit 034f2c9, reversing
changes made to 3d1b95d.
@pewsheen pewsheen changed the base branch from dev to 1.x September 7, 2023 12:35
@pewsheen
Copy link
Contributor Author

pewsheen commented Sep 7, 2023

Just noticed that this was opened against dev, let's rebase and open it against 1.x so we could roll it out in 1.5

omg. It's a mess now

I'll close this one and create another PR later.

@pewsheen pewsheen closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.